Changeset 52059 for trunk/src/wp-admin/includes/media.php

Timestamp:

11/08/2021 10:47:09 PM (19 months ago)

Author:

antpb

Message:

Media: Change upload button to a file input for better e2e targeting.

Changes the media library upload button to input type="file" for better end to end testing capabilities.

Props justinahinon, joedolson, sabernhardt, audrasjb.
Fixes #54168.

File:

• trunk/src/wp-admin/includes/media.php (modified) (2 diffs)

trunk/src/wp-admin/includes/media.php

@@ -2247 +2247 @@
         <p class="drag-drop-info"><?php _e( 'Drop files to upload' ); ?></p>
         <p><?php _ex( 'or', 'Uploader: Drop files here - or - Select Files' ); ?></p>
-        <p class="drag-drop-buttons"><input id="plupload-browse-button" type="button" value="<?php esc_attr_e( 'Select Files' ); ?>" class="button" /></p>
+        <p class="drag-drop-buttons"><label for="plupload-browse-button" id="plupload-browse-label" class="button button-hero"><?php esc_html_e( 'Select Files' ); ?></label><input id="plupload-browse-button" type="file" class="screen-reader-text" aria-labelledby="plupload-browse-label post-upload-info" /></p>
         </div>
     </div>
@@ -2289 +2289 @@
     </div>
 
-<p class="max-upload-size">
+<p class="max-upload-size" id="post-upload-info">
     <?php
     /* translators: %s: Maximum allowed file size. */