Changeset 52061 for trunk/src/wp-includes/bookmark-template.php

Timestamp:

11/08/2021 11:05:50 PM (5 years ago)

Author:

hellofromTonya

Message:

General: Add "noopener" to wp_list_bookmarks() output.

In the bookmarks walker _walk_bookmarks(), add a 'noopener' to the bookmark's rel attribute when there's target attribute.

Adds a new test class for wp_list_bookmarks() and tests for this change.

Follow-up to [3880], [10712].

Props birgire, costdev, hellofromTonya, mukesh27 , sergeybiryukov, tw2113.
Fixes #53839.

File:

• trunk/src/wp-includes/bookmark-template.php (modified) (1 diff)

trunk/src/wp-includes/bookmark-template.php

@@ -103 +103 @@
                 }
                 $rel = $bookmark->link_rel;
+
+                $target = $bookmark->link_target;
+                if ( '' !== $target ) {
+                        if ( is_string( $rel ) && '' !== $rel ) {
+                                if ( ! str_contains( $rel, 'noopener' ) ) {
+                                        $rel = trim( $rel ) . ' noopener';
+                                }
+                        } else {
+                                $rel = 'noopener';
+                        }
+
+                        $target = ' target="' . $target . '"';
+                }
+
                 if ( '' !== $rel ) {
                         $rel = ' rel="' . esc_attr( $rel ) . '"';
                 }
-                $target = $bookmark->link_target;
-                if ( '' !== $target ) {
-                        $target = ' target="' . $target . '"';
-                }
+
                 $output .= '<a href="' . $the_link . '"' . $rel . $title . $target . '>';