Changeset 52085

Timestamp:

11/09/2021 10:58:39 PM (4 years ago)

Author:

hellofromTonya

Message:

HTTP API: Ensure value returned from 'http_allowed_safe_ports' is an array to avoid PHP 8+ TypeError fatal error.

Adds an is_array() check before the in_array(). Why? in_array() requires a array for the haystack. Any other data type will cause a fatal error on PHP 8.0 or higher:

Fatal error: Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array

As this is a new filter, this type check properly guards to avoid the fatal error.

Follow-up to [52084].

See #54331.

File:

• trunk/src/wp-includes/http.php (modified) (1 diff)

trunk/src/wp-includes/http.php

@@ -594 +594 @@
      */
     $allowed_ports = apply_filters( 'http_allowed_safe_ports', array( 80, 443, 8080 ), $host, $url );
-    if ( in_array( $port, $allowed_ports, true ) ) {
+    if ( is_array( $allowed_ports ) && in_array( $port, $allowed_ports, true ) ) {
         return $url;
     }