Changeset 52146 for trunk/tests/phpunit/tests/rest-api/rest-block-directory-controller.php

Timestamp:

11/12/2021 01:45:05 PM (3 years ago)

Author:

hellofromTonya

Message:

Build/Test Tools: Mock no results remote request in WP_REST_Block_Directory_Controller:: get_items().

• Refactors the mock logic to a helper function for reuse in multiple tests.
• Mocks the remote request in WP_REST_Block_Directory_Controller_Test:: test_get_items_no_results() using the mock helper.

Follow-up to [48242], [52137].

Props hellofromTonya, sergeybiryukov.
See #54420.

File:

• trunk/tests/phpunit/tests/rest-api/rest-block-directory-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-block-directory-controller.php

@@ -70 +70 @@
     public function test_get_items() {
         wp_set_current_user( self::$admin_id );
-        add_filter(
-            'pre_http_request',
-            static function() {
-                /*
-                 * Mocks the request to:
-                 * https://api.wordpress.org/plugins/info/1.2/?action=query_plugins&request%5Bblock%5D=foo&request%5Bper_page%5D=10&request%5Bpage%5D=1&request%5Blocale%5D=en_US&request%5Bwp_version%5D=5.9
-                 */
-                return array(
-                    'headers'  => array(),
-                    'response' => array(
-                        'code'    => 200,
-                        'message' => 'OK',
-                    ),
-                    'body'     => '{"info":{"page":1,"pages":0,"results":0},"plugins":[]}',
-                    'cookies'  => array(),
-                    'filename' => null,
-                );
-            }
+        $this->mock_remote_request(
+            array(
+                'body' => '{"info":{"page":1,"pages":0,"results":0},"plugins":[]}',
+            )
         );
 
@@ -129 +115 @@
     public function test_get_items_no_results() {
         wp_set_current_user( self::$admin_id );
+        $this->mock_remote_request(
+            array(
+                'body' => '{"info":{"page":1,"pages":0,"results":0},"plugins":[]}',
+            )
+        );
 
         $request = new WP_REST_Request( 'GET', '/wp/v2/block-directory/search' );
@@ -307 +298 @@
         );
     }
+
+    /**
+     * Mocks the remote request via `'pre_http_request'` filter by
+     * returning the expected response.
+     *
+     * @since 5.9.0
+     *
+     * @param array $expected Expected response, which is merged with the default response.
+     */
+    private function mock_remote_request( array $expected ) {
+        add_filter(
+            'pre_http_request',
+            static function() use ( $expected ) {
+                $default = array(
+                    'headers'  => array(),
+                    'response' => array(
+                        'code'    => 200,
+                        'message' => 'OK',
+                    ),
+                    'body'     => '',
+                    'cookies'  => array(),
+                    'filename' => null,
+                );
+                return array_merge( $default, $expected );
+            }
+        );
+    }
 }