Changeset 52168

Timestamp:

11/15/2021 09:53:26 PM (5 years ago)

Author:

joedolson

Message:

Media: Featured image modal loads only selected image.

Fix bug introduced in [50829] that caused media modal to only load the selected image. Executes .more() when loading the modal to ensure that the media collection is available.

Props manishamakhija, birgire, dilipbheda, afercia, hellofromTonya.
Fixes #42937.

Location:

trunk

Files:

• src/js/_enqueues/lib/ajax-response.js (modified) (3 diffs)
• src/wp-admin/includes/ajax-actions.php (modified) (1 diff)
• tests/phpunit/tests/ajax/AddTag.php (added)

trunk/src/js/_enqueues/lib/ajax-response.js

@@ -19 +19 @@
         },
         parseAjaxResponse: function( x, r, e ) { // 1 = good, 0 = strange (bad data?), -1 = you lack permission.
-                var parsed = {}, re = jQuery('#' + r).empty(), err = '';
+                var parsed = {}, re = jQuery('#' + r).empty(), err = '', successmsg = '';
 
                 if ( x && typeof x === 'object' && x.getElementsByTagName('wp_ajax') ) {
@@ -28 +28 @@
                                 response = { action: th.attr('action'), what: child.get(0).nodeName, id: child.attr('id'), oldId: child.attr('old_id'), position: child.attr('position') };
                                 response.data = jQuery( 'response_data', child ).text();
+                                successmsg += response.data;
                                 response.supplemental = {};
                                 if ( !jQuery( 'supplemental', child ).children().each( function() {
@@ -47 +48 @@
                                 parsed.responses.push( response );
                         } );
-                        if ( err.length ) { re.html( '<div class="error">' + err + '</div>' ); }
+                        if ( err.length ) {
+                                re.html( '<div class="error">' + err + '</div>' );
+                                wp.a11y.speak( err );
+                        } else {
+                                re.html( '<div class="updated notice is-dismissible"><p>' + successmsg + '</p></div>');
+                                jQuery(document).trigger( 'wp-updates-notice-added' );
+                                wp.a11y.speak( successmsg );
+                        }
                         return parsed;
                 }

trunk/src/wp-admin/includes/ajax-actions.php

@@ -1103 +1103 @@
         $parents = ob_get_clean();
 
+        require ABSPATH . 'wp-admin/includes/edit-tag-messages.php';
+
+        $message = '';
+        if ( isset( $messages[ $tax->name ][1] ) ) {
+                $message = $messages[ $tax->name ][1];
+        } elseif ( isset( $messages['_item'][1] ) ) {
+                $message = $messages['_item'][1];
+        }
+
         $x->add(
                 array(
                         'what'         => 'taxonomy',
+                        'data'         => $message,
                         'supplemental' => compact( 'parents', 'noparents' ),
                 )