Changeset 52194

Timestamp:

11/17/2021 03:23:40 AM (3 years ago)

Author:

peterwilsoncc

Message:

Posts, Post Types: Use global post as the default for wp_get_post_parent_id().

Convert the $post parameter of wp_get_post_parent_id() to optional, defaulting to the current global post object when called within the loop.

Props danielpost, davidbaumwald, SergeyBiryukov, birgire, audrasjb, hellofromTonya, TimothyBlynJacobs.
Fixes #48358.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/wpGetPostParentId.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -7643 +7643 @@
  *
  * @since 3.1.0
- *
- * @param int|WP_Post $post Post ID or post object.
+ * @since 5.9.0 The `$post` parameter was made optional.
+ *
+ * @param int|WP_Post|null $post Optional. Post ID or post object. Defaults to global $post.
  * @return int|false Post parent ID (which can be 0 if there is no parent),
  *                   or false if the post does not exist.
  */
-function wp_get_post_parent_id( $post ) {
+function wp_get_post_parent_id( $post = null ) {
     $post = get_post( $post );
     if ( ! $post || is_wp_error( $post ) ) {

trunk/tests/phpunit/tests/post/wpGetPostParentId.php

@@ -34 +34 @@
     }
 
+    /**
+     * @ticket 48358
+     * @covers ::wp_get_post_parent_id
+     */
+    public function test_wp_get_post_parent_id_with_no_post_argument_default_to_global_post_id() {
+        $GLOBALS['post'] = get_post( self::$post_id );
+        $this->assertSame( self::$parent_post_id, wp_get_post_parent_id() );
+    }
+
     public function test_wp_get_post_parent_id_with_non_existing_id_default_to_global_post_id() {
         $GLOBALS['post'] = get_post( self::$post_id );