WordPress.org

Make WordPress Core

Changeset 52196


Ignore:
Timestamp:
11/17/2021 03:54:40 PM (2 months ago)
Author:
joedolson
Message:

Media: Move dismiss upload errors button after errors.

Change the button that dismissess upload errors so it appears after the relevant errors. Change button from icon-only to text-based. Removes ambiguity about what you are cancelling when using the control.

Props ComputerGuru, melchoyce, vdwijngaert, alexislloyd, joedolson, shaunandrews, sabernhardt.
Fixes #42979.

Location:
trunk/src
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/css/media.css

    r51727 r52196  
    506506    box-shadow: none;
    507507    background: none;
    508 }
    509 
    510 .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors {
    511     top: -10px;
    512     right: -14px;
    513     padding: 10px;
    514 }
    515 
    516 .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors:before {
    517     content: "\f153";
    518     display: block;
    519     font: normal 16px/1 dashicons;
    520     color: #787c82;
    521 }
    522 
    523 .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors:focus:before,
    524 .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors:hover:before {
    525     color: #d63638;
    526508}
    527509
  • trunk/src/wp-includes/css/media-views.css

    r51727 r52196  
    14381438
    14391439.media-uploader-status .upload-dismiss-errors {
    1440     position: absolute;
    1441     top: -3px;
    1442     right: -5px;
    1443     padding: 5px;
    1444     border-radius: 50%;
    14451440    transition: none;
    14461441    text-decoration: none;
    1447 }
    1448 
    1449 .uploader-inline .media-uploader-status .upload-dismiss-errors {
    1450     top: 2px;
    1451     right: 2px;
    1452 }
    1453 
    1454 .media-uploader-status .upload-dismiss-errors::before {
    1455     content: "\f153";
    1456     display: block;
    1457     font: normal 16px/1 dashicons;
    1458     color: #787c82;
    1459 }
    1460 
    1461 .uploader-inline .errors.media-uploader-status .upload-dismiss-errors::before {
    1462     color: #646970;
    1463 }
    1464 
    1465 .errors.media-uploader-status .upload-dismiss-errors:hover::before,
    1466 .errors.media-uploader-status .upload-dismiss-errors:focus::before {
    1467     color: #d63638;
    14681442}
    14691443
  • trunk/src/wp-includes/media-template.php

    r52171 r52196  
    321321    <script type="text/html" id="tmpl-uploader-status">
    322322        <h2><?php _e( 'Uploading' ); ?></h2>
    323         <button type="button" class="button-link upload-dismiss-errors"><span class="screen-reader-text"><?php _e( 'Dismiss Errors' ); ?></span></button>
    324323
    325324        <div class="media-progress-bar"><div></div></div>
     
    332331        </div>
    333332        <div class="upload-errors"></div>
     333        <button type="button" class="button upload-dismiss-errors"><?php _e( 'Dismiss errors' ); ?></button>
    334334    </script>
    335335
Note: See TracChangeset for help on using the changeset viewer.