Changeset 52230

Timestamp:

11/21/2021 07:26:08 PM (3 years ago)

Author:

audrasjb

Message:

Editor: Do not provide initial_edits for properties that are not supported by the current post type.

Previously, the block editor initialization always provided "title", "content" and "excerpt" initial edits in the initializeEditor call even though these properties might not be supported by the current post type being edited. This leads to a bug in the post editor where as soon as one would open a "new post", the editor considers the content "dirty", meaning changes are applied and it is not possible to leave the editor without encountering an "unsaved changes" notice.

This change updates the $initial_edits variable declaration to only provide the properties that are supported by the current post type.

Props youknowriad, h71.
Fixes #53813.

File:

• trunk/src/wp-admin/edit-form-blocks.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-blocks.php

@@ -78 +78 @@
  * but should be included in its save payload.
  */
-$initial_edits = null;
+$initial_edits = array();
 $is_new_post   = false;
 if ( 'auto-draft' === $post->post_status ) {
     $is_new_post = true;
     // Override "(Auto Draft)" new post default title with empty string, or filtered value.
-    $initial_edits = array(
-        'title'   => $post->post_title,
-        'content' => $post->post_content,
-        'excerpt' => $post->post_excerpt,
-    );
+    if ( post_type_supports( $post->post_type, 'title' ) ) {
+        $initial_edits['title'] = $post->post_title;
+    }
+
+    if ( post_type_supports( $post->post_type, 'content' ) ) {
+        $initial_edits['content'] = $post->post_content;
+    }
+
+    if ( post_type_supports( $post->post_type, 'excerpt' ) ) {
+        $initial_edits['excerpt'] = $post->post_excerpt;
+    }
 }