Changeset 52243

Timestamp:

11/25/2021 01:05:30 AM (5 years ago)

Author:

noisysocks

Message:

Themes: Move the skip link to outside the canvas in block themes

Fix Twenty Twenty-one having an erroneous margin above the Header template part
by moving the skip link outside of the wp-site-blocks canvas.

This is a backport of ​https://github.com/WordPress/gutenberg/pull/34986.

Props youknowriad.
Fixes #54491.

File:

• trunk/src/wp-includes/theme-templates.php (modified) (3 diffs)

trunk/src/wp-includes/theme-templates.php

@@ -166 +166 @@
         ( function() {
                 var skipLinkTarget = document.querySelector( 'main' ),
-                        parentEl,
+                        sibling,
                         skipLinkTargetID,
                         skipLink;
@@ -177 +177 @@
                 // Get the site wrapper.
                 // The skip-link will be injected in the beginning of it.
-                parentEl = document.querySelector( '.wp-site-blocks' );
+                sibling = document.querySelector( '.wp-site-blocks' );
 
                 // Early exit if the root element was not found.
-                if ( ! parentEl ) {
+                if ( ! sibling ) {
                         return;
                 }
@@ -198 +198 @@
 
                 // Inject the skip link.
-                parentEl.insertAdjacentElement( 'afterbegin', skipLink );
+                sibling.parentElement.insertBefore( skipLink, sibling );
         }() );
         </script>