Changeset 52245

Timestamp:

11/25/2021 08:34:01 AM (2 years ago)

Author:

audrasjb

Message:

Media: Replace some array keys with their numeric equivalent.

This change replaces ['0'] with [0] which brings better consistency, readability and performance.

Props chintan1896, adamsilverstein, costdev.
Fixes #53540.

Location:

trunk/src

Files:

• wp-admin/includes/media.php (modified) (2 diffs)
• wp-includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -3741 +3741 @@
         case 'matroska':
         case 'webm':
-            if ( isset( $metadata['matroska']['comments']['creation_time']['0'] ) ) {
-                $creation_date = strtotime( $metadata['matroska']['comments']['creation_time']['0'] );
-            } elseif ( isset( $metadata['matroska']['info']['0']['DateUTC_unix'] ) ) {
-                $creation_date = (int) $metadata['matroska']['info']['0']['DateUTC_unix'];
+            if ( isset( $metadata['matroska']['comments']['creation_time'][0] ) ) {
+                $creation_date = strtotime( $metadata['matroska']['comments']['creation_time'][0] );
+            } elseif ( isset( $metadata['matroska']['info'][0]['DateUTC_unix'] ) ) {
+                $creation_date = (int) $metadata['matroska']['info'][0]['DateUTC_unix'];
             }
             break;
@@ -3750 +3750 @@
         case 'quicktime':
         case 'mp4':
-            if ( isset( $metadata['quicktime']['moov']['subatoms']['0']['creation_time_unix'] ) ) {
-                $creation_date = (int) $metadata['quicktime']['moov']['subatoms']['0']['creation_time_unix'];
+            if ( isset( $metadata['quicktime']['moov']['subatoms'][0]['creation_time_unix'] ) ) {
+                $creation_date = (int) $metadata['quicktime']['moov']['subatoms'][0]['creation_time_unix'];
             }
             break;

trunk/src/wp-includes/media.php

@@ -1130 +1130 @@
 function wp_get_attachment_image_url( $attachment_id, $size = 'thumbnail', $icon = false ) {
     $image = wp_get_attachment_image_src( $attachment_id, $size, $icon );
-    return isset( $image['0'] ) ? $image['0'] : false;
+    return isset( $image[0] ) ? $image[0] : false;
 }