Changeset 52248 for trunk/tests/phpunit/tests/menu/walker-nav-menu.php

Timestamp:

11/25/2021 07:39:31 PM (3 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Correct the order and naming of expected and actual values in various tests.

This corrects the order of the parameters when used in assertions so if/when they fail the failure message is correct.

See #53363

File:

• trunk/tests/phpunit/tests/menu/walker-nav-menu.php (modified) (2 diffs)

trunk/tests/phpunit/tests/menu/walker-nav-menu.php

@@ -42 +42 @@
      */
     public function test_noopener_no_referrer_for_target_blank() {
-        $expected   = '';
+        $actual     = '';
         $post_id    = $this->factory->post->create();
         $post_title = get_the_title( $post_id );
@@ -62 +62 @@
         );
 
-        $this->walker->start_el( $expected, (object) $item, 0, (object) $args );
+        $this->walker->start_el( $actual, (object) $item, 0, (object) $args );
 
-        $this->assertSame( "<li id=\"menu-item-{$post_id}\" class=\"menu-item-{$post_id}\"><a target=\"_blank\" rel=\"noopener\">{$post_title}</a>", $expected );
+        $this->assertSame( "<li id=\"menu-item-{$post_id}\" class=\"menu-item-{$post_id}\"><a target=\"_blank\" rel=\"noopener\">{$post_title}</a>", $actual );
     }