Changeset 52248 for trunk/tests/phpunit/tests/meta/registerMeta.php

Timestamp:

11/25/2021 07:39:31 PM (5 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Correct the order and naming of expected and actual values in various tests.

This corrects the order of the parameters when used in assertions so if/when they fail the failure message is correct.

See #53363

File:

• trunk/tests/phpunit/tests/meta/registerMeta.php (modified) (4 diffs)

trunk/tests/phpunit/tests/meta/registerMeta.php

@@ -180 +180 @@
                         ),
                 );
-                $this->assertSame( $actual, $expected );
+                $this->assertSame( $expected, $actual );
         }
 
@@ -522 +522 @@
                 $object_id            = self::$$object_property_name;
                 $default_value        = get_metadata_default( $object_type, $object_id, $meta_key, $single );
-                $this->assertSame( $default_value, $expected );
+                $this->assertSame( $expected, $default_value );
 
                 // Check for default value.
                 $value = get_metadata( $object_type, $object_id, $meta_key, $single );
-                $this->assertSame( $value, $expected );
+                $this->assertSame( $expected, $value );
 
                 // Set value to check default is not being returned by mistake.
@@ -537 +537 @@
                 delete_metadata( $object_type, $object_id, $meta_key );
                 $value = get_metadata( $object_type, $object_id, $meta_key, $single );
-                $this->assertSame( $value, $expected );
+                $this->assertSame( $expected, $value );
 
                 // Set other meta key, to make sure other keys are not effects.
@@ -569 +569 @@
                 $object_id            = self::$$object_property_name;
                 $default_value        = get_metadata_default( $object_type, $object_id, $meta_key, $single );
-                $this->assertSame( $default_value, $expected );
+                $this->assertSame( $expected, $default_value );
         }