Changeset 52248 for trunk/tests/phpunit/tests/query/commentCount.php

Timestamp:

11/25/2021 07:39:31 PM (5 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Correct the order and naming of expected and actual values in various tests.

This corrects the order of the parameters when used in assertions so if/when they fail the failure message is correct.

See #53363

File:

• trunk/tests/phpunit/tests/query/commentCount.php (modified) (15 diffs)

trunk/tests/phpunit/tests/query/commentCount.php

@@ -82 +82 @@
                 $expected = self::$post_ids[4];
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -100 +100 @@
                 $expected = self::$post_ids[5];
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -118 +118 @@
                 $expected = array();
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
         public function test_operator_less_than() {
@@ -144 +144 @@
                 }
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -162 +162 @@
                 $expected = array();
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -190 +190 @@
                 }
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
 
         }
@@ -214 +214 @@
                 }
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -232 +232 @@
                 $expected = array();
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -256 +256 @@
                 }
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -274 +274 @@
                 $expected = array();
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -295 +295 @@
                 }
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -313 +313 @@
                 $expected = array();
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -330 +330 @@
                 $expected = self::$post_ids[5];
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -354 +354 @@
                 }
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 
@@ -369 +369 @@
                 $expected = self::$post_ids[5];
 
-                $this->assertSameSets( $found_post_ids, $expected );
+                $this->assertSameSets( $expected, $found_post_ids );
         }
 }