Changeset 52255

Timestamp:

11/26/2021 11:41:24 AM (5 years ago)

Author:

audrasjb

Message:

Taxonomy: Use WP_Term object to retrieve the taxonomy in get_term_feed_link().

This change fixes a backward compatibility issue introduced in [52180] where get_term_feed_link() did not honor the $taxonomy parameter anymore. Rather than using the default category taxonomy when passing a term ID in get_term_feed_link(), use the WP_Term object to get the taxonomy.

Follow-up to [52180].

Props hugod.
Fixes #50225.

Location:

trunk

Files:

• src/wp-includes/link-template.php (modified) (1 diff)
• tests/phpunit/tests/term/getTermLink.php (modified) (1 diff)

trunk/src/wp-includes/link-template.php

@@ -931 +931 @@
 function get_term_feed_link( $term, $taxonomy = '', $feed = '' ) {
         if ( ! is_object( $term ) ) {
-                $term     = (int) $term;
-                $taxonomy = 'category';
-        } elseif ( ! $term instanceof WP_Term ) {
-                $taxonomy = $term->taxonomy;
+                $term = (int) $term;
         }
 
         $term = get_term( $term, $taxonomy );
+
+        $taxonomy = $term->taxonomy;
 
         if ( empty( $term ) || is_wp_error( $term ) ) {

trunk/tests/phpunit/tests/term/getTermLink.php

@@ -267 +267 @@
 
         /**
+         * @dataProvider data_get_term_link
+         *
+         * @ticket 50225
+         *
+         * @param string $taxonomy Taxonomy been tested (used for index of term keys).
+         * @param bool   $use_id   When true, pass term ID. Else, skip the test.
+         */
+        public function test_get_term_feed_link_backward_compatibility( $taxonomy, $use_id ) {
+                if ( $use_id ) {
+                        $term = $this->get_term( $taxonomy, $use_id );
+
+                        $term_feed_link = get_term_feed_link( $term, $taxonomy );
+                        $this->assertIsString( $term_feed_link );
+
+                        $term_feed_link = get_term_feed_link( $term, '' );
+                        $this->assertIsString( $term_feed_link );
+                } else {
+                        $this->markTestSkipped( 'This test requires to pass an id to get_term_feed_link()' );
+                }
+        }
+
+        /**
          * Data provider.
          *