Changeset 52266 for trunk/tests/phpunit/tests/block-template.php

Timestamp:

11/29/2021 08:45:31 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Replace assertEquals() with assertSame() in block template tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame(), assertSameSets(), or assertSameSetsWithIndex() should generally be preferred, to make the tests more reliable.

Follow-up to [51003], [51079], [52062], [52265].

See #53364, #53363, #54335.

File:

• trunk/tests/phpunit/tests/block-template.php (modified) (7 diffs)

trunk/tests/phpunit/tests/block-template.php

@@ -1 +1 @@
 <?php
 /**
- * Block_Template_Test class
+ * Tests_Block_Template class
  *
  * @package WordPress
@@ -37 +37 @@
         );
         $resolved_template_path = locate_block_template( get_stylesheet_directory() . '/page-home.php', $type, $templates );
-        $this->assertEquals( self::$template_canvas_path, $resolved_template_path );
+        $this->assertSame( self::$template_canvas_path, $resolved_template_path );
         $this->assertStringEqualsFile( get_stylesheet_directory() . '/templates/page-home.html', $_wp_current_template_content );
     }
@@ -50 +50 @@
         );
         $resolved_template_path = locate_block_template( get_stylesheet_directory() . '/page.php', $type, $templates );
-        $this->assertEquals( self::$template_canvas_path, $resolved_template_path );
+        $this->assertSame( self::$template_canvas_path, $resolved_template_path );
         $this->assertStringEqualsFile( get_stylesheet_directory() . '/templates/page.html', $_wp_current_template_content );
     }
@@ -61 +61 @@
         );
         $resolved_template_path = locate_block_template( get_stylesheet_directory() . '/index.php', $type, $templates );
-        $this->assertEquals( self::$template_canvas_path, $resolved_template_path );
+        $this->assertSame( self::$template_canvas_path, $resolved_template_path );
         $this->assertStringEqualsFile( get_stylesheet_directory() . '/templates/index.html', $_wp_current_template_content );
     }
@@ -81 +81 @@
         );
         $resolved_template_path = locate_block_template( $page_id_template_path, $type, $templates );
-        $this->assertEquals( $page_id_template_path, $resolved_template_path );
+        $this->assertSame( $page_id_template_path, $resolved_template_path );
     }
 
@@ -111 +111 @@
         );
         $resolved_template_path  = locate_block_template( $page_slug_template_path, $type, $templates );
-        $this->assertEquals( $page_slug_template_path, $resolved_template_path );
+        $this->assertSame( $page_slug_template_path, $resolved_template_path );
     }
 
@@ -128 +128 @@
         );
         $resolved_template_path          = locate_block_template( $parent_theme_page_template_path, $type, $templates );
-        $this->assertEquals( self::$template_canvas_path, $resolved_template_path );
+        $this->assertSame( self::$template_canvas_path, $resolved_template_path );
         $this->assertStringEqualsFile( get_stylesheet_directory() . '/templates/page-1.html', $_wp_current_template_content );
     }