Changeset 52276 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-menu-items-controller.php

Timestamp:

11/30/2021 01:08:05 AM (4 years ago)

Author:

peterwilsoncc

Message:

REST API: Fire wp_after_insert_post later in new post object endpoints.

In the new menu items, global items and template controllers manually call the function wp_after_insert_post() to manually fire the action of the same name after all potential data is updated.

This accounts for the use case in which a theme or plugin developer has modified the endpoints use of either taxonomy or meta data.

The new parameter $fire_after_hooks is added to wp_update_nav_menu_item() to control whether the wp_after_insert_post action is fired when it in turn calls wp_insert_post().

Props spacedmonkey, peterwilsoncc, zieladam.
Fixes #54536.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-menu-items-controller.php (modified) (6 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-menu-items-controller.php

@@ -123 +123 @@
         $prepared_nav_item = (array) $prepared_nav_item;
 
-        $nav_menu_item_id = wp_update_nav_menu_item( $prepared_nav_item['menu-id'], $prepared_nav_item['menu-item-db-id'], wp_slash( $prepared_nav_item ) );
+        $nav_menu_item_id = wp_update_nav_menu_item( $prepared_nav_item['menu-id'], $prepared_nav_item['menu-item-db-id'], wp_slash( $prepared_nav_item ), false );
         if ( is_wp_error( $nav_menu_item_id ) ) {
             if ( 'db_insert_error' === $nav_menu_item_id->get_error_code() ) {
@@ -182 +182 @@
         do_action( 'rest_after_insert_nav_menu_item', $nav_menu_item, $request, true );
 
-        $response = $this->prepare_item_for_response( get_post( $nav_menu_item_id ), $request );
+        $post = get_post( $nav_menu_item_id );
+        wp_after_insert_post( $post, false, null );
+
+        $response = $this->prepare_item_for_response( $post, $request );
         $response = rest_ensure_response( $response );
 
@@ -205 +208 @@
             return $valid_check;
         }
-
+        $post_before       = get_post( $request['id'] );
         $prepared_nav_item = $this->prepare_item_for_database( $request );
 
@@ -214 +217 @@
         $prepared_nav_item = (array) $prepared_nav_item;
 
-        $nav_menu_item_id = wp_update_nav_menu_item( $prepared_nav_item['menu-id'], $prepared_nav_item['menu-item-db-id'], wp_slash( $prepared_nav_item ) );
+        $nav_menu_item_id = wp_update_nav_menu_item( $prepared_nav_item['menu-id'], $prepared_nav_item['menu-item-db-id'], wp_slash( $prepared_nav_item ), false );
 
         if ( is_wp_error( $nav_menu_item_id ) ) {
@@ -246 +249 @@
         }
 
+        $post          = get_post( $nav_menu_item_id );
         $nav_menu_item = $this->get_nav_menu_item( $nav_menu_item_id );
         $fields_update = $this->update_additional_fields_for_object( $nav_menu_item, $request );
@@ -257 +261 @@
         /** This action is documented in wp-includes/rest-api/endpoints/class-wp-rest-menu-items-controller.php */
         do_action( 'rest_after_insert_nav_menu_item', $nav_menu_item, $request, false );
+
+        wp_after_insert_post( $post, true, $post_before );
 
         $response = $this->prepare_item_for_response( get_post( $nav_menu_item_id ), $request );