Changeset 52288

Timestamp:

11/30/2021 07:05:52 PM (5 years ago)

Author:

hellofromTonya

Message:

Media: Use infiniteScrolling global setting in js/media/controllers/featured-image.js and js/media/controllers/replace-image.js.

Follow-up to [52287] which added an undefined variable. The variable should have been the global wp.media.view.settings.infiniteScrolling. This commit brings that global setting into each of the functions and renames the variable using camelCase to comply with JS coding standards.

Follow-up to [52287].

Props SergeyBiryukov.
Fixes #53765.

Location:

trunk/src/js/media/controllers

Files:

• featured-image.js (modified) (2 diffs)
• replace-image.js (modified) (1 diff)

trunk/src/js/media/controllers/featured-image.js

@@ -109 +109 @@
                         library = this.get('library'),
                         id = wp.media.view.settings.post.featuredImageId,
+                        infiniteScrolling = wp.media.view.settings.infiniteScrolling,
                         attachment;
 
@@ -118 +119 @@
                 selection.reset( attachment ? [ attachment ] : [] );
 
-                if ( ! infinite_scrolling && library.hasMore() ) {
+                if ( ! infiniteScrolling && library.hasMore() ) {
                         library.more();
                 }

trunk/src/js/media/controllers/replace-image.js

@@ -101 +101 @@
                 var selection = this.get('selection'),
                         library = this.get('library'),
-                        attachment = this.image.attachment;
+                        attachment = this.image.attachment,
+                        infiniteScrolling = wp.media.view.settings.infiniteScrolling;
 
                 selection.reset( attachment ? [ attachment ] : [] );
 
-                if ( ! infinite_scrolling && library.getTotalAttachments() == 0 && library.hasMore() ) {
+                if ( ! infiniteScrolling && library.getTotalAttachments() === 0 && library.hasMore() ) {
                         library.more();
                 }