Changeset 52322

Timestamp:

12/04/2021 05:18:48 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Break the $path reference after a foreach loop in block_editor_rest_api_preload().

When using a foreach loop with a value assigned by reference, the variable continues to point to the last array element even after the loop, so it is recommended to destroy it by unset() to avoid unexpected behavior later on.

See ​PHP Manual: foreach.

Follow-up to [52312], [52313].

Props TobiasBg.
See #54558.

File:

• trunk/src/wp-includes/block-editor.php (modified) (5 diffs)

trunk/src/wp-includes/block-editor.php

@@ -84 +84 @@
      */
     $block_categories = apply_filters( 'block_categories_all', $block_categories, $block_editor_context );
+
     if ( ! empty( $block_editor_context->post ) ) {
         $post = $block_editor_context->post;
@@ -124 +125 @@
      */
     $allowed_block_types = apply_filters( 'allowed_block_types_all', $allowed_block_types, $block_editor_context );
+
     if ( ! empty( $block_editor_context->post ) ) {
         $post = $block_editor_context->post;
@@ -398 +400 @@
      */
     $editor_settings = apply_filters( 'block_editor_settings_all', $editor_settings, $block_editor_context );
+
     if ( ! empty( $block_editor_context->post ) ) {
         $post = $block_editor_context->post;
@@ -441 +444 @@
      */
     $preload_paths = apply_filters( 'block_editor_rest_api_preload_paths', $preload_paths, $block_editor_context );
+
     if ( ! empty( $block_editor_context->post ) ) {
         $selected_post = $block_editor_context->post;
@@ -479 +483 @@
         }
     }
+
+    unset( $path );
 
     $preload_data = array_reduce(