Changeset 52330 for trunk/src/wp-admin/menu.php

Timestamp:

12/07/2021 12:00:45 AM (4 years ago)

Author:

hellofromTonya

Message:

Themes: Better names for WP_Theme::is_block_theme() and wp_is_block_theme() and make wp_is_block_theme() a wrapper.

This commit renames the following method and function to better represent block theme terminology:

• WP_Theme::is_block_based() to WP_Theme::is_block_theme()
• wp_is_block_template_theme() to wp_is_block_theme()

It also changes wp_is_block_theme() to be a helper wrapper (sugar syntax) for wp_get_theme()->is_block_theme();. Why? To ensure both the method and function behave the same, to help Gutenberg maintain WordPress cross-version compatibility, and to make it less cumbersome to port changes from Gutenberg to Core.

Follow-up to [52069], [52247], [52279].

Props antonvlasenko, costdev, hellofromTonya, noisysocks.
Fixes #54550.

File:

• trunk/src/wp-admin/menu.php (modified) (3 diffs)

trunk/src/wp-admin/menu.php

@@ -203 +203 @@
     $submenu['themes.php'][5] = array( sprintf( __( 'Themes %s' ), $count ), $appearance_cap, 'themes.php' );
 
-if ( wp_is_block_template_theme() ) {
+if ( wp_is_block_theme() ) {
     $submenu['themes.php'][6] = array(
         sprintf(
@@ -217 +217 @@
 // Hide Customize link on block themes unless a plugin or theme is using
 // customize_register to add a setting.
-if ( ! wp_is_block_template_theme() || has_action( 'customize_register' ) ) {
+if ( ! wp_is_block_theme() || has_action( 'customize_register' ) ) {
     $customize_url = add_query_arg( 'return', urlencode( remove_query_arg( wp_removable_query_args(), wp_unslash( $_SERVER['REQUEST_URI'] ) ) ), 'customize.php' );
-    $position      = wp_is_block_template_theme() ? 7 : 6;
+    $position      = wp_is_block_theme() ? 7 : 6;
 
     $submenu['themes.php'][ $position ] = array( __( 'Customize' ), 'customize', esc_url( $customize_url ), '', 'hide-if-no-customize' );
@@ -256 +256 @@
 function _add_themes_utility_last() {
     add_submenu_page(
-        wp_is_block_template_theme() ? 'tools.php' : 'themes.php',
+        wp_is_block_theme() ? 'tools.php' : 'themes.php',
         __( 'Theme Editor' ),
         __( 'Theme Editor' ),