Changeset 52337

Timestamp:

12/07/2021 04:49:22 PM (3 years ago)

Author:

hellofromTonya

Message:

Upgrade/Install: Fix moving plugins folder in WP_Upgrader:: move_to_temp_backup_dir().

[51815] introduced the creation of a temporary backup of plugins before updating.

The move() (and later, move_dir()) call) uses a $src parameter.
For Hello Dolly, this is <path>/wp-contents/plugins/. (note the period at the end).

For users on Linux and Mac, this doesn't appear to cause any problems.
However, on Windows, the move causes the plugins folder to be moved which then causes a failure when attempting to call mkdir().

This commit skips any plugin whose slug is '.' as this slug results in the $src value ending in a period.

Follow-up to [51815].

Props costdev, boniu91, hellofromTonya.
Fixes #54543.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -1026 +1026 @@
         }
 
+        /**
+         * Skip any plugin that has "." as its slug.
+         * A slug of "." will result in a `$src` value ending in a period.
+         *
+         * On Windows, this will cause the 'plugins' folder to be moved,
+         * and will cause a failure when attempting to call `mkdir()`.
+         */
+        if ( '.' === $args['slug'] ) {
+            return false;
+        }
+
         $dest_dir = $wp_filesystem->wp_content_dir() . 'upgrade/temp-backup/';
         // Create the temp-backup directory if it doesn't exist.