Changeset 52340 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-edit-site-export-controller.php

Timestamp:

12/07/2021 06:36:29 PM (3 years ago)

Author:

spacedmonkey

Message:

REST API: Ensure that the export template endpoint returns a valid WP_Error object.

Ensure that the export template endpoint returns a WP_Error object, including code and message, so that the site editor can display an error message.
Add some basic unit tests to ensure that permission checks are working as expected.

Follow-up to [52286].

Props Spacedmonkey, dlh, hellofromTonya , Mamaduka, TimothyBlynJacobs.
Fixes #54448.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-edit-site-export-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-edit-site-export-controller.php

@@ -55 +55 @@
     public function permissions_check() {
         if ( ! current_user_can( 'edit_theme_options' ) ) {
-            new WP_Error(
-                'rest_cannot_view_url_details',
+            return new WP_Error(
+                'rest_cannot_export_templates',
                 __( 'Sorry, you are not allowed to export templates and template parts.' ),
                 array( 'status' => rest_authorization_required_code() )