Changeset 52372 for trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

Timestamp:

12/14/2021 04:12:57 PM (3 years ago)

Author:

hellofromTonya

Message:

Themes: Rename public static functions in WP_Theme_JSON_Resolver to remove custom_post_type references.

WordPress Core is not really custom and does not reference "custom post type" in its function naming. This commit renames 2 public static methods:

• WP_Theme_JSON_Resolver::get_user_custom_post_type_id() renamed to WP_Theme_JSON_Resolver::get_user_global_styles_post_id().
• WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type() renamed to WP_Theme_JSON_Resolver:: get_user_data_from_wp_global_styles().

Follow-up to [52049], [52051], [52069], [52232], [52275], [52364].

Props antonvlasenko, bernhard-reiter, costdev, desrosj, hellofromTonya, noisysocks, oandregal, SergeyBiryukov.
Fixes #54517.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

@@ -322 +322 @@
     }
 
-    function test_get_user_data_from_custom_post_type_does_not_use_uncached_queries() {
+    function test_get_user_data_from_wp_global_styles_does_not_use_uncached_queries() {
         add_filter( 'query', array( $this, 'filter_db_query' ) );
         $query_count = count( $this->queries );
         for ( $i = 0; $i < 3; $i++ ) {
-            WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type( wp_get_theme() );
+            WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( wp_get_theme() );
             WP_Theme_JSON_Resolver::clean_cached_data();
         }
         $query_count = count( $this->queries ) - $query_count;
-        $this->assertEquals( 1, $query_count, 'Only one SQL query should be peformed for multiple invocations of WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type()' );
-
-        $user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type( wp_get_theme() );
+        $this->assertEquals( 1, $query_count, 'Only one SQL query should be peformed for multiple invocations of WP_Theme_JSON_Resolver::get_global_styles_from_post()' );
+
+        $user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( wp_get_theme() );
         $this->assertEmpty( $user_cpt );
 
-        $user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type( wp_get_theme(), true );
+        $user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( wp_get_theme(), true );
         $this->assertNotEmpty( $user_cpt );
 
         $query_count = count( $this->queries );
         for ( $i = 0; $i < 3; $i++ ) {
-            WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type( wp_get_theme() );
+            WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( wp_get_theme() );
             WP_Theme_JSON_Resolver::clean_cached_data();
         }