Make WordPress Core


Ignore:
Timestamp:
12/14/2021 04:29:03 PM (2 years ago)
Author:
spacedmonkey
Message:

REST API: Ensure that the get_theme_item method should respect fields param.

Fix the get_theme_item method in the WP_REST_Global_Styles_Controller class to respect the fields param context filtering and to return links.

Props spacedmonkey, hellofromtonya, peterwilsoncc, costdev.
Fixes #54595.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/rest-global-styles-controller.php

    r52342 r52374  
    153153        $response = rest_get_server()->dispatch( $request );
    154154        $data     = $response->get_data();
    155         unset( $data['_links'] );
    156 
     155        $links    = $response->get_links();
    157156        $this->assertArrayHasKey( 'settings', $data );
    158157        $this->assertArrayHasKey( 'styles', $data );
     158        $this->assertArrayHasKey( 'self', $links );
     159        $this->assertStringContainsString( '/wp/v2/global-styles/themes/tt1-blocks', $links['self'][0]['href'] );
     160    }
     161
     162    /**
     163     * @covers WP_REST_Global_Styles_Controller::get_theme_item
     164     * @ticket 54595
     165     */
     166    public function test_get_theme_item_fields() {
     167        wp_set_current_user( self::$admin_id );
     168        $request = new WP_REST_Request( 'GET', '/wp/v2/global-styles/themes/tt1-blocks' );
     169        $request->set_param( '_fields', 'settings' );
     170        $response = rest_get_server()->dispatch( $request );
     171        $data     = $response->get_data();
     172        $this->assertArrayHasKey( 'settings', $data );
     173        $this->assertArrayNotHasKey( 'styles', $data );
    159174    }
    160175
     
    224239        $response = rest_get_server()->dispatch( $request );
    225240        $data     = $response->get_data();
    226         unset( $data['_links'] );
     241        $links    = $response->get_links();
    227242
    228243        $this->assertEquals(
     
    238253            $data
    239254        );
     255
     256        $this->assertArrayHasKey( 'self', $links );
     257        $this->assertStringContainsString( '/wp/v2/global-styles/' . self::$global_styles_id, $links['self'][0]['href'] );
    240258    }
    241259
Note: See TracChangeset for help on using the changeset viewer.