Changeset 52376 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php

Timestamp:

12/14/2021 06:22:07 PM (3 years ago)

Author:

hellofromTonya

Message:

REST API: Add block theme support for valid non-alphanumeric characters in theme's directory name.

Themes whose wp-content/themes/<dirname> include valid non-alphanumeric (cross-platform) characters work for non-block themes, but did not previously resolve for block themes. For example, a block theme in wp-content/themes/twentytwentytwo-0.4.0/ directory resulted a 404 "No route was found matching the URL and request method" response when attempting to customize it in the Site Editor.

This commit adds support for the following characters in a theme's root directory: _, ., @, [, ], (, and ). Subdirectory themes and - are already supported.

Follow-up to [51003], [52051], [52275].

Props mkaz, costdev, hellofromTonya, jffng, justinahinon, peterwilsoncc, spacedmonkey, TimothyBlynJacobs.
Fixes #54596.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php

@@ -69 +69 @@
         register_rest_route(
             $this->namespace,
-            '/' . $this->rest_base . '/(?P<id>[\/\w-]+)',
+            '/' . $this->rest_base . '/(?P<id>[\/\s%\w\.\(\)\[\]\@_\-]+)',
             array(
                 'args'   => array(
@@ -150 +150 @@
      */
     public function _sanitize_template_id( $id ) {
+        // Decode empty space.
+        $id = urldecode( $id );
+
         $last_slash_pos = strrpos( $id, '/' );
         if ( false === $last_slash_pos ) {