Changeset 52376 for trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

Timestamp:

12/14/2021 06:22:07 PM (5 years ago)

Author:

hellofromTonya

Message:

REST API: Add block theme support for valid non-alphanumeric characters in theme's directory name.

Themes whose wp-content/themes/<dirname> include valid non-alphanumeric (cross-platform) characters work for non-block themes, but did not previously resolve for block themes. For example, a block theme in wp-content/themes/twentytwentytwo-0.4.0/ directory resulted a 404 "No route was found matching the URL and request method" response when attempting to customize it in the Site Editor.

This commit adds support for the following characters in a theme's root directory: _, ., @, [, ], (, and ). Subdirectory themes and - are already supported.

Follow-up to [51003], [52051], [52275].

Props mkaz, costdev, hellofromTonya, jffng, justinahinon, peterwilsoncc, spacedmonkey, TimothyBlynJacobs.
Fixes #54596.

File:

• trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

@@ -70 +70 @@
         }
 
+        /**
+         * @ticket 54596
+         */
         public function test_expected_routes_in_schema() {
                 $routes = rest_get_server()->get_routes();
@@ -133 +136 @@
                         '/wp/v2/comments',
                         '/wp/v2/comments/(?P<id>[\\d]+)',
-                        '/wp/v2/global-styles/(?P<id>[\/\w-]+)',
-                        '/wp/v2/global-styles/themes/(?P<stylesheet>[^.\/]+(?:\/[^.\/]+)?)',
+                        '/wp/v2/global-styles/(?P<id>[\/\s%\w\.\(\)\[\]\@_\-]+)',
+                        '/wp/v2/global-styles/themes/(?P<stylesheet>[\/\s%\w\.\(\)\[\]\@_\-]+)',
                         '/wp/v2/search',
                         '/wp/v2/block-renderer/(?P<name>[a-z0-9-]+/[a-z0-9-]+)',
@@ -142 +145 @@
                         '/wp/v2/settings',
                         '/wp/v2/template-parts',
-                        '/wp/v2/template-parts/(?P<id>[\/\w-]+)',
+                        '/wp/v2/template-parts/(?P<id>[\/\s%\w\.\(\)\[\]\@_\-]+)',
                         '/wp/v2/template-parts/(?P<id>[\d]+)/autosaves',
                         '/wp/v2/template-parts/(?P<parent>[\d]+)/autosaves/(?P<id>[\d]+)',
@@ -148 +151 @@
                         '/wp/v2/template-parts/(?P<parent>[\d]+)/revisions/(?P<id>[\d]+)',
                         '/wp/v2/templates',
-                        '/wp/v2/templates/(?P<id>[\/\w-]+)',
+                        '/wp/v2/templates/(?P<id>[\/\s%\w\.\(\)\[\]\@_\-]+)',
                         '/wp/v2/templates/(?P<id>[\d]+)/autosaves',
                         '/wp/v2/templates/(?P<parent>[\d]+)/autosaves/(?P<id>[\d]+)',