Changeset 52376 for trunk/tests/phpunit/tests/rest-api/wpRestTemplatesController.php

Timestamp:

12/14/2021 06:22:07 PM (2 years ago)

Author:

hellofromTonya

Message:

REST API: Add block theme support for valid non-alphanumeric characters in theme's directory name.

Themes whose wp-content/themes/<dirname> include valid non-alphanumeric (cross-platform) characters work for non-block themes, but did not previously resolve for block themes. For example, a block theme in wp-content/themes/twentytwentytwo-0.4.0/ directory resulted a 404 "No route was found matching the URL and request method" response when attempting to customize it in the Site Editor.

This commit adds support for the following characters in a theme's root directory: _, ., @, [, ], (, and ). Subdirectory themes and - are already supported.

Follow-up to [51003], [52051], [52275].

Props mkaz, costdev, hellofromTonya, jffng, justinahinon, peterwilsoncc, spacedmonkey, TimothyBlynJacobs.
Fixes #54596.

File:

• trunk/tests/phpunit/tests/rest-api/wpRestTemplatesController.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/wpRestTemplatesController.php

@@ -54 +54 @@
     }
 
+    /**
+     * @covers WP_REST_Templates_Controller::register_routes
+     * @ticket 54596
+     */
     public function test_register_routes() {
         $routes = rest_get_server()->get_routes();
-        $this->assertArrayHasKey( '/wp/v2/templates', $routes );
-        $this->assertArrayHasKey( '/wp/v2/templates/(?P<id>[\/\w-]+)', $routes );
+        $this->assertArrayHasKey(
+            '/wp/v2/templates',
+            $routes,
+            'Templates route does not exist'
+        );
+        $this->assertArrayHasKey(
+            '/wp/v2/templates/(?P<id>[\/\s%\w\.\(\)\[\]\@_\-]+)',
+            $routes,
+            'Single template based on the given ID route does not exist'
+        );
     }