Changeset 52382 for trunk/tests/phpunit/tests/admin/includesFile.php

Timestamp:

12/15/2021 07:59:32 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Mock the HTTP request response in download_url() tests.

This aims to speed up the tests and minimize unrelated failures by avoiding an unnecessary external HTTP request, while still performing the intended functionality checks.

Update similar helpers in some other tests to use more consistent terminology.

Follow-up to [37907], [46175], [51626].

See #54420, #53363.

File:

• trunk/tests/phpunit/tests/admin/includesFile.php (modified) (3 diffs)

trunk/tests/phpunit/tests/admin/includesFile.php

@@ -292 +292 @@
      */
     public function test_download_url_no_warning_for_url_without_path() {
+        // Hook a mocked HTTP request response.
+        add_filter( 'pre_http_request', array( $this, 'mock_http_request' ), 10, 3 );
+
         $result = download_url( 'https://example.com' );
 
@@ -307 +310 @@
      */
     public function test_download_url_no_warning_for_url_without_path_with_signature_verification() {
+        // Hook a mocked HTTP request response.
+        add_filter( 'pre_http_request', array( $this, 'mock_http_request' ), 10, 3 );
+
         add_filter(
             'wp_signature_hosts',
@@ -327 +333 @@
         $this->assertSame( 'signature_verification_no_signature', $error->get_error_code() );
     }
+
+    /**
+     * Mock the HTTP request response.
+     *
+     * @param bool   $false     False.
+     * @param array  $arguments Request arguments.
+     * @param string $url       Request URL.
+     * @return array|bool
+     */
+    public function mock_http_request( $false, $arguments, $url ) {
+        if ( 'https://example.com' === $url ) {
+            return array(
+                'response' => array(
+                    'code' => 200,
+                ),
+            );
+        }
+
+        return $false;
+    }
 }