Changeset 52382 for trunk/tests/phpunit/tests/http/wpGetHttpHeaders.php

Timestamp:

12/15/2021 07:59:32 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Mock the HTTP request response in download_url() tests.

This aims to speed up the tests and minimize unrelated failures by avoiding an unnecessary external HTTP request, while still performing the intended functionality checks.

Update similar helpers in some other tests to use more consistent terminology.

Follow-up to [37907], [46175], [51626].

See #54420, #53363.

File:

• trunk/tests/phpunit/tests/http/wpGetHttpHeaders.php (modified) (2 diffs)

trunk/tests/phpunit/tests/http/wpGetHttpHeaders.php

@@ -13 +13 @@
         parent::set_up();
 
-        // Hook a fake HTTP request response.
-        add_filter( 'pre_http_request', array( $this, 'fake_http_request' ), 10, 3 );
+        // Hook a mocked HTTP request response.
+        add_filter( 'pre_http_request', array( $this, 'mock_http_request' ), 10, 3 );
     }
 
@@ -48 +48 @@
      * @param array  $arguments Request arguments.
      * @param string $url       Request URL.
-     *
      * @return array|bool
      */
-    public function fake_http_request( $false, $arguments, $url ) {
+    public function mock_http_request( $false, $arguments, $url ) {
         if ( 'http://example.com' === $url ) {
             return array( 'headers' => true );