Changeset 52389 for trunk/tests/phpunit/tests/user.php

Timestamp:

12/19/2021 01:42:37 PM (3 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Reduce the use of unnecessary randomness in tests.

This increases the overall reliability of the tests.

Props johnillo

Fixes #37371

File:

• trunk/tests/phpunit/tests/user.php (modified) (7 diffs)

trunk/tests/phpunit/tests/user.php

@@ -105 +105 @@
 
         // Change and get again.
-        $val2 = rand_str();
+        $val2 = 'baz';
         update_user_option( self::$author_id, $key, $val2 );
         $this->assertSame( $val2, get_user_option( $key, self::$author_id ) );
@@ -136 +136 @@
         update_user_meta( self::$author_id, $key, $val );
         // Incorrect key: key still exists.
-        delete_user_meta( self::$author_id, $key, rand_str() );
+        delete_user_meta( self::$author_id, $key, 'foo' );
         $this->assertSame( $val, get_user_meta( self::$author_id, $key, true ) );
         // Correct key: deleted.
@@ -150 +150 @@
         // Some values to set.
         $vals = array(
-            rand_str() => 'val-' . rand_str(),
-            rand_str() => 'val-' . rand_str(),
-            rand_str() => 'val-' . rand_str(),
+            'key0' => 'val0',
+            'key1' => 'val1',
+            'key2' => 'val2',
         );
 
@@ -476 +476 @@
             'post_author'  => self::$author_id,
             'post_status'  => 'publish',
-            'post_content' => rand_str(),
-            'post_title'   => rand_str(),
+            'post_content' => 'content',
+            'post_title'   => 'title',
             'post_type'    => 'post',
         );
@@ -637 +637 @@
         $id1 = wp_insert_user(
             array(
-                'user_login' => rand_str(),
+                'user_login' => 'taco_burrito',
                 'user_pass'  => 'password',
                 'user_email' => 'taco@burrito.com',
@@ -646 +646 @@
         $id2 = wp_insert_user(
             array(
-                'user_login' => rand_str(),
+                'user_login' => 'taco_burrito2',
                 'user_pass'  => 'password',
                 'user_email' => 'taco@burrito.com',
@@ -827 +827 @@
     public function test_wp_insert_user_should_not_wipe_existing_password() {
         $user_details = array(
-            'user_login' => rand_str(),
+            'user_login' => 'jonsnow',
             'user_pass'  => 'password',
-            'user_email' => rand_str() . '@example.com',
+            'user_email' => 'jonsnow@example.com',
         );