Changeset 52390

Timestamp:

12/19/2021 02:27:22 PM (3 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Remove the assertion in filter_rest_url_for_leading_slash().

This assertion can mask the fact that some other tests don't perform an assertion.

Fixes #54661

File:

• trunk/tests/phpunit/includes/testcase-rest-controller.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase-rest-controller.php

@@ -46 +46 @@
 
         // Make sure path for rest_url has a leading slash for proper resolution.
-        $this->assertTrue( 0 === strpos( $path, '/' ), 'REST API URL should have a leading slash.' );
+        if ( 0 !== strpos( $path, '/' ) ) {
+            $this->fail(
+                sprintf(
+                    'REST API URL "%s" should have a leading slash.',
+                    $path
+                )
+            );
+        }
 
         return $url;