Changeset 52418

Timestamp:

12/26/2021 11:40:50 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Separate the tests for recommended PHP and MySQL versions in readme.html

This aims to simplify the individual tests and reduce duplication using a helper function.

Follow-up to [52260], [52319], [52358].

See #41490.

File:

• trunk/tests/phpunit/tests/external-http/basic.php (modified) (4 diffs)

trunk/tests/phpunit/tests/external-http/basic.php

@@ -10 +10 @@
          * @covers ::wp_remote_retrieve_body
          */
-        public function test_readme() {
+        public function test_readme_php_version() {
                 // This test is designed to only run on trunk/master.
                 $this->skipOnAutomatedBranches();
@@ -18 +18 @@
                 preg_match( '#Recommendations.*PHP</a> version <strong>([0-9.]*)#s', $readme, $matches );
 
-                $response = wp_remote_get( 'https://www.php.net/supported-versions.php' );
+                $response_body = $this->get_response_body( 'https://www.php.net/supported-versions.php' );
+
+                preg_match_all( '#<tr class="stable">\s*<td>\s*<a [^>]*>\s*([0-9.]*)#s', $response_body, $phpmatches );
+
+                // TODO: Enable this check once PHP 8.0 compatibility is achieved.
+                // $this->assertContains( $matches[1], $phpmatches[1], "readme.html's Recommended PHP version is too old. Remember to update the WordPress.org Requirements page, too." );
+        }
+
+        /**
+         * @covers ::wp_remote_get
+         * @covers ::wp_remote_retrieve_response_code
+         * @covers ::wp_remote_retrieve_body
+         */
+        public function test_readme_mysql_version() {
+                // This test is designed to only run on trunk/master.
+                $this->skipOnAutomatedBranches();
+
+                $readme = file_get_contents( ABSPATH . 'readme.html' );
+
+                preg_match( '#Recommendations.*MySQL</a> version <strong>([0-9.]*)#s', $readme, $matches );
+
+                $response_body = $this->get_response_body( "https://dev.mysql.com/doc/relnotes/mysql/{$matches[1]}/en/" );
+
+                preg_match( '#(\d{4}-\d{2}-\d{2}), General Availability#', $response_body, $mysqlmatches );
+
+                // Per https://www.mysql.com/support/, Oracle actively supports MySQL releases for 5 years from GA release.
+                $mysql_eol = strtotime( $mysqlmatches[1] . ' +5 years' );
+
+                $this->assertLessThan( $mysql_eol, time(), "readme.html's Recommended MySQL version is too old. Remember to update the WordPress.org Requirements page, too." );
+        }
+
+        /**
+         * Helper function to retrieve the response body or skip the test on HTTP timeout.
+         *
+         * @param string $url The URL to retrieve the response from.
+         * @return string The response body.
+         */
+        public function get_response_body( $url ) {
+                $response = wp_remote_get( $url );
 
                 $this->skipTestOnTimeout( $response );
@@ -26 +64 @@
 
                 if ( 200 !== $response_code ) {
+                        $parsed_url = parse_url( $url );
+
                         $error_message = sprintf(
-                                'Could not contact PHP.net to check versions. Response code: %s. Response body: %s',
+                                'Could not contact %1$s to check versions. Response code: %2$s. Response body: %3$s',
+                                $parsed_url['host'],
                                 $response_code,
                                 $response_body
@@ -39 +80 @@
                 }
 
-                preg_match_all( '#<tr class="stable">\s*<td>\s*<a [^>]*>\s*([0-9.]*)#s', $response_body, $phpmatches );
-
-                // TODO: Enable this check once PHP 8.0 compatibility is achieved.
-                // $this->assertContains( $matches[1], $phpmatches[1], "readme.html's Recommended PHP version is too old. Remember to update the WordPress.org Requirements page, too." );
-
-                preg_match( '#Recommendations.*MySQL</a> version <strong>([0-9.]*)#s', $readme, $matches );
-
-                $response = wp_remote_get( "https://dev.mysql.com/doc/relnotes/mysql/{$matches[1]}/en/" );
-
-                $this->skipTestOnTimeout( $response );
-
-                $response_code = wp_remote_retrieve_response_code( $response );
-                $response_body = wp_remote_retrieve_body( $response );
-
-                if ( 200 !== $response_code ) {
-                        $error_message = sprintf(
-                                'Could not contact dev.MySQL.com to check versions. Response code: %s. Response body: %s',
-                                $response_code,
-                                $response_body
-                        );
-
-                        if ( 503 === $response_code ) {
-                                $this->markTestSkipped( $error_message );
-                        }
-
-                        $this->fail( $error_message );
-                }
-
-                preg_match( '#(\d{4}-\d{2}-\d{2}), General Availability#', $response_body, $mysqlmatches );
-
-                // Per https://www.mysql.com/support/, Oracle actively supports MySQL releases for 5 years from GA release.
-                $mysql_eol = strtotime( $mysqlmatches[1] . ' +5 years' );
-
-                $this->assertLessThan( $mysql_eol, time(), "readme.html's Recommended MySQL version is too old. Remember to update the WordPress.org Requirements page, too." );
+                return $response_body;
         }
 }