Changeset 52439

Timestamp:

01/04/2022 06:38:52 PM (3 years ago)

Author:

hellofromTonya

Message:

Themes: Make block themes support HTML5 by default.

For block themes, [52369] added HTML5 support for 'comment-list', 'comment-form', 'style', and 'script'. However, when sites upgrade to 5.9 with non-block content such as a gallery and caption, the markup was not HTML5.

This commit adds full HTML5 theme feature support for block themes. Non-block content such as a [gallery] and [caption] shortcodes will natively be in HMTL5 markup without block themes needing to specifically add add_theme_support( 'html5, .. ) to the theme.

Follow-up to [24417], [27302], [34261], [52369], [52383], [52386].

Props @joyously, costdev, hellofromTonya, audrasjb, Mamaduka, ocean90.
Fixes #54731. See #54597.

Location:

trunk

Files:

• src/wp-includes/theme.php (modified) (1 diff)
• tests/phpunit/tests/theme.php (modified) (2 diffs)

trunk/src/wp-includes/theme.php

@@ -4182 +4182 @@
     add_theme_support( 'responsive-embeds' );
     add_theme_support( 'editor-styles' );
-    add_theme_support( 'html5', array( 'comment-form', 'comment-list', 'style', 'script' ) );
+    /*
+     * Makes block themes support HTML5 by default for the comment block and search form
+     * (which use default template functions) and `[caption]` and `[gallery]` shortcodes. 
+     * Other blocks contain their own HTML5 markup.
+     */
+    add_theme_support( 'html5', array( 'comment-form', 'comment-list', 'search-form', 'gallery', 'caption', 'style', 'script' ) );
     add_theme_support( 'automatic-feed-links' );
 

trunk/tests/phpunit/tests/theme.php

@@ -707 +707 @@
      *
      * @ticket 54597
+     * @ticket 54731
+     *
      * @dataProvider data_block_theme_has_default_support
      *
@@ -762 +764 @@
                 'support' => array(
                     'feature' => 'editor-styles',
+                ),
+            ),
+            'html5: comment-list'  => array(
+                'support' => array(
+                    'feature'     => 'html5',
+                    'sub_feature' => 'comment-list',
+                ),
+            ),
+            'html5: comment-form'  => array(
+                'support' => array(
+                    'feature'     => 'html5',
+                    'sub_feature' => 'comment-form',
+                ),
+            ),
+            'html5: search-form'   => array(
+                'support' => array(
+                    'feature'     => 'html5',
+                    'sub_feature' => 'search-form',
+                ),
+            ),
+            'html5: gallery'       => array(
+                'support' => array(
+                    'feature'     => 'html5',
+                    'sub_feature' => 'gallery',
+                ),
+            ),
+            'html5: caption'       => array(
+                'support' => array(
+                    'feature'     => 'html5',
+                    'sub_feature' => 'caption',
                 ),
             ),