WordPress.org

Make WordPress Core

Changeset 52439


Ignore:
Timestamp:
01/04/2022 06:38:52 PM (3 weeks ago)
Author:
hellofromTonya
Message:

Themes: Make block themes support HTML5 by default.

For block themes, [52369] added HTML5 support for 'comment-list', 'comment-form', 'style', and 'script'. However, when sites upgrade to 5.9 with non-block content such as a gallery and caption, the markup was not HTML5.

This commit adds full HTML5 theme feature support for block themes. Non-block content such as a [gallery] and [caption] shortcodes will natively be in HMTL5 markup without block themes needing to specifically add add_theme_support( 'html5, .. ) to the theme.

Follow-up to [24417], [27302], [34261], [52369], [52383], [52386].

Props @joyously, costdev, hellofromTonya, audrasjb, Mamaduka, ocean90.
Fixes #54731. See #54597.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/theme.php

    r52383 r52439  
    41824182    add_theme_support( 'responsive-embeds' );
    41834183    add_theme_support( 'editor-styles' );
    4184     add_theme_support( 'html5', array( 'comment-form', 'comment-list', 'style', 'script' ) );
     4184    /*
     4185     * Makes block themes support HTML5 by default for the comment block and search form
     4186     * (which use default template functions) and `[caption]` and `[gallery]` shortcodes.
     4187     * Other blocks contain their own HTML5 markup.
     4188     */
     4189    add_theme_support( 'html5', array( 'comment-form', 'comment-list', 'search-form', 'gallery', 'caption', 'style', 'script' ) );
    41854190    add_theme_support( 'automatic-feed-links' );
    41864191
  • trunk/tests/phpunit/tests/theme.php

    r52389 r52439  
    707707     *
    708708     * @ticket 54597
     709     * @ticket 54731
     710     *
    709711     * @dataProvider data_block_theme_has_default_support
    710712     *
     
    762764                'support' => array(
    763765                    'feature' => 'editor-styles',
     766                ),
     767            ),
     768            'html5: comment-list'  => array(
     769                'support' => array(
     770                    'feature'     => 'html5',
     771                    'sub_feature' => 'comment-list',
     772                ),
     773            ),
     774            'html5: comment-form'  => array(
     775                'support' => array(
     776                    'feature'     => 'html5',
     777                    'sub_feature' => 'comment-form',
     778                ),
     779            ),
     780            'html5: search-form'   => array(
     781                'support' => array(
     782                    'feature'     => 'html5',
     783                    'sub_feature' => 'search-form',
     784                ),
     785            ),
     786            'html5: gallery'       => array(
     787                'support' => array(
     788                    'feature'     => 'html5',
     789                    'sub_feature' => 'gallery',
     790                ),
     791            ),
     792            'html5: caption'       => array(
     793                'support' => array(
     794                    'feature'     => 'html5',
     795                    'sub_feature' => 'caption',
    764796                ),
    765797            ),
Note: See TracChangeset for help on using the changeset viewer.