Changeset 52450

Timestamp:

01/05/2022 05:35:44 PM (3 years ago)

Author:

davidbaumwald

Message:

Login and Registration: Remove aria-expanded from "Generate Password" button.

During password resets, the 'Generate Password" button has a aria-expanded="true" attribute, but the button itself does not expand or collapse anything. This change adds a skip-aria-expanded class to the button which is referenced in JavaScript to skip updating the aria-expanded attribute on the button itself when clicked.

This change also resets the aria-expanded attribute to false for the parent form after it's submitted.

Props alexstine, johnjamesjacoby, sabernhardt.
Fixes #54538.

Location:

trunk/src

Files:

• js/_enqueues/admin/user-profile.js (modified) (2 diffs)
• wp-login.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/user-profile.js

@@ -217 +217 @@
 
             // Make sure the password fields are shown.
-            $generateButton.attr( 'aria-expanded', 'true' );
+            $generateButton.not( '.skip-aria-expanded' ).attr( 'aria-expanded', 'true' );
             $passwordWrapper
                 .show()
@@ -258 +258 @@
             // Stop an empty password from being submitted as a change.
             $submitButtons.prop( 'disabled', false );
+
+            $generateButton.attr( 'aria-expanded', 'false' );
         } );
 

trunk/src/wp-login.php

@@ -980 +980 @@
             <input type="hidden" name="rp_key" value="<?php echo esc_attr( $rp_key ); ?>" />
             <p class="submit reset-pass-submit">
-                <button type="button" class="button wp-generate-pw hide-if-no-js" aria-expanded="true"><?php _e( 'Generate Password' ); ?></button>
+                <button type="button" class="button wp-generate-pw hide-if-no-js skip-aria-expanded"><?php _e( 'Generate Password' ); ?></button>
                 <input type="submit" name="wp-submit" id="wp-submit" class="button button-primary button-large" value="<?php esc_attr_e( 'Save Password' ); ?>" />
             </p>