Changeset 52462 for branches/5.9/src/wp-admin/includes/upgrade.php

Timestamp:

01/06/2022 05:26:43 PM (3 years ago)

Author:

desrosj

Message:

Upgrade/Install: Avoid using unserialize() unnecessarily.

Merges [52456] to the 5.9 branch.
Props vortfu, xknown, dd32.

Location:

branches/5.9

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/upgrade.php (modified) (1 diff)

branches/5.9/src/wp-admin/includes/upgrade.php

@@ -1622 +1622 @@
         while ( $rows = $wpdb->get_results( "SELECT option_name, option_value FROM $wpdb->options ORDER BY option_id LIMIT $start, 20" ) ) {
             foreach ( $rows as $row ) {
-                $value = $row->option_value;
-                if ( ! @unserialize( $value ) ) {
+                $value = maybe_unserialize( $row->option_value );
+                if ( $value === $row->option_value ) {
                     $value = stripslashes( $value );
                 }