Changeset 52464

Timestamp:

01/06/2022 05:34:05 PM (3 years ago)

Author:

desrosj

Message:

Formatting: Correctly encode ASCII characters in post slugs.

Merges [52457] to the 5.9 branch.
Props zieladam, whyisjake, xknown, peterwilsoncc, desrosj, iandunn.

Location:

branches/5.9

Files:

• . (modified) (1 prop)
• src/wp-includes/formatting.php (modified) (2 diffs)
• src/wp-includes/post.php (modified) (1 diff)

branches/5.9/src/wp-includes/formatting.php

@@ -1139 +1139 @@
  *
  * @since 1.5.0
- *
- * @param string $utf8_string
- * @param int    $length Max  length of the string
+ * @since 5.8.3 Added the `encode_ascii_characters` parameter.
+ *
+ * @param string $utf8_string             String to encode.
+ * @param int    $length                  Max length of the string
+ * @param bool   $encode_ascii_characters Whether to encode ascii characters such as < " '
  * @return string String with Unicode encoded for URI.
  */
-function utf8_uri_encode( $utf8_string, $length = 0 ) {
+function utf8_uri_encode( $utf8_string, $length = 0, $encode_ascii_characters = false ) {
     $unicode        = '';
     $values         = array();
@@ -1159 +1161 @@
 
         if ( $value < 128 ) {
-            if ( $length && ( $unicode_length >= $length ) ) {
+            $char                = chr( $value );
+            $encoded_char        = $encode_ascii_characters ? rawurlencode( $char ) : $char;
+            $encoded_char_length = strlen( $encoded_char );
+            if ( $length && ( $unicode_length + $encoded_char_length ) > $length ) {
                 break;
             }
-            $unicode .= chr( $value );
-            $unicode_length++;
+            $unicode        .= $encoded_char;
+            $unicode_length += $encoded_char_length;
         } else {
             if ( count( $values ) == 0 ) {

branches/5.9/src/wp-includes/post.php

@@ -5143 +5143 @@
             $slug = substr( $slug, 0, $length );
         } else {
-            $slug = utf8_uri_encode( $decoded_slug, $length );
+            $slug = utf8_uri_encode( $decoded_slug, $length, true );
         }
     }