Changeset 5248

Timestamp:

04/12/2007 02:27:12 AM (18 years ago)

Author:

ryan

Message:

Actually make use of wp_cache_add to avoid unnecessary cache writes. Props skeltoac. fixes #4138

Location:

trunk/wp-includes

Files:

• bookmark.php (modified) (1 diff)
• category.php (modified) (3 diffs)
• functions.php (modified) (2 diffs)
• general-template.php (modified) (1 diff)
• post.php (modified) (2 diffs)

trunk/wp-includes/bookmark.php

@@ -137 +137 @@
 
     $cache[ $key ] = $results;
-    wp_cache_set( 'get_bookmarks', $cache, 'bookmark' );
+    wp_cache_add( 'get_bookmarks', $cache, 'bookmark' );
 
     return apply_filters('get_bookmarks', $results, $r);

trunk/wp-includes/category.php

@@ -9 +9 @@
     if ( ! $cat_ids = wp_cache_get('all_category_ids', 'category') ) {
         $cat_ids = $wpdb->get_col("SELECT cat_ID FROM $wpdb->categories");
-        wp_cache_set('all_category_ids', $cat_ids, 'category');
+        wp_cache_add('all_category_ids', $cat_ids, 'category');
     }
 
@@ -140 +140 @@
 
     $cache[ $key ] = $categories;
-    wp_cache_set( 'get_categories', $cache, 'category' );
+    wp_cache_add( 'get_categories', $cache, 'category' );
 
     $categories = apply_filters('get_categories', $categories, $r);
@@ -161 +161 @@
         if ( ! $_category = wp_cache_get($category, 'category') ) {
             $_category = $wpdb->get_row("SELECT * FROM $wpdb->categories WHERE cat_ID = '$category' LIMIT 1");
-            wp_cache_set($category, $_category, 'category');
+            wp_cache_add($category, $_category, 'category');
         }
     }

trunk/wp-includes/functions.php

@@ -230 +230 @@
             if( is_object( $row) ) { // Has to be get_row instead of get_var because of funkiness with 0, false, null values
                 $value = $row->option_value;
-                wp_cache_set($setting, $value, 'options');
+                wp_cache_add($setting, $value, 'options');
             } else { // option does not exist, so we must cache its non-existence
                 $notoptions[$setting] = true;
@@ -295 +295 @@
         foreach ( (array) $alloptions_db as $o )
             $alloptions[$o->option_name] = $o->option_value;
-        wp_cache_set('alloptions', $alloptions, 'options');
+        wp_cache_add('alloptions', $alloptions, 'options');
     }
     return $alloptions;

trunk/wp-includes/general-template.php

@@ -636 +636 @@
     echo $output;
     $cache[ $key ] = $output;
-    wp_cache_set( 'get_calendar', $cache, 'calendar' );
+    wp_cache_add( 'get_calendar', $cache, 'calendar' );
 }
 

trunk/wp-includes/post.php

@@ -1013 +1013 @@
     if ( ! $page_ids = wp_cache_get('all_page_ids', 'pages') ) {
         $page_ids = $wpdb->get_col("SELECT ID FROM $wpdb->posts WHERE post_type = 'page'");
-        wp_cache_set('all_page_ids', $page_ids, 'pages');
+        wp_cache_add('all_page_ids', $page_ids, 'pages');
     }
 
@@ -1056 +1056 @@
                 // Potential issue: we're not checking to see if the post_type = 'page'
                 // So all non-'post' posts will get cached as pages.
-                wp_cache_set($_page->ID, $_page, 'pages');
+                wp_cache_add($_page->ID, $_page, 'pages');
             }
         }