Make WordPress Core


Ignore:
Timestamp:
01/06/2022 06:26:53 PM (2 years ago)
Author:
desrosj
Message:

Grouped backports to the 3.8 branch.

  • Query: Improve sanitization within WP_Tax_Query.
  • Upgrade/Install: Avoid using unserialize() unnecessarily.
  • Formatting: Correctly encode ASCII characters in post slugs.

Merges [52454,52456-52457] to the 3.8 branch.
Props vortfu, dd32, ehtis, zieladam, whyisjake, xknown, peterwilsoncc, desrosj, iandunn.

Location:
branches/3.8
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/3.8

  • branches/3.8/src/wp-includes/formatting.php

    r47661 r52485  
    678678 *
    679679 * @since 1.5.0
     680 * @since 5.8.3 Added the `encode_ascii_characters` parameter.
    680681 *
    681682 * @param string $utf8_string
    682683 * @param int $length Max length of the string
     684 * @param bool   $encode_ascii_characters Whether to encode ascii characters such as < " '
    683685 * @return string String with Unicode encoded for URI.
    684686 */
    685 function utf8_uri_encode( $utf8_string, $length = 0 ) {
     687function utf8_uri_encode( $utf8_string, $length = 0, $encode_ascii_characters = false ) {
    686688    $unicode = '';
    687689    $values = array();
     
    695697
    696698        if ( $value < 128 ) {
    697             if ( $length && ( $unicode_length >= $length ) )
     699            $char                = chr( $value );
     700            $encoded_char        = $encode_ascii_characters ? rawurlencode( $char ) : $char;
     701            $encoded_char_length = strlen( $encoded_char );
     702            if ( $length && ( $unicode_length + $encoded_char_length ) > $length ) {
    698703                break;
    699             $unicode .= chr($value);
    700             $unicode_length++;
     704            }
     705            $unicode        .= $encoded_char;
     706            $unicode_length += $encoded_char_length;
    701707        } else {
    702708            if ( count( $values ) == 0 ) $num_octets = ( $value < 224 ) ? 2 : 3;
Note: See TracChangeset for help on using the changeset viewer.