Changeset 52546

Timestamp:

01/10/2022 04:43:54 PM (3 years ago)

Author:

davidbaumwald

Message:

Build/Test Tools: Re-enable E2E tests for the 5.8 branch.

After the 5.9 branch was created, [52449] updated the workflow for testing old branches to include 5.9. However, the E2E tests -branch condition was updated to 5.9 instead of adding an additional branch condition for 5.9. This commit re-enables the E2E tests for 5.8.

Props desrosj, hellofromTonya.
Fixes #54749.

File:

• trunk/.github/workflows/test-old-branches.yml (modified) (1 diff)

trunk/.github/workflows/test-old-branches.yml

@@ -46 +46 @@
             workflow: 'php-compatibility.yml'
 
-          # End to End testing was introduced in 5.3 but later removed as there were no meaningful assertions.
-          # Only the officially supported major branch runs E2E tests so that more assertions can be added, and the
-          # workflow does not continue to run needlessly on old branches.
+          # End-to-end testing was introduced in 5.3 but was later removed as there were no meaningful assertions.
+          # Starting in 5.8 with #52905, some additional tests with real assertions were introduced.
+          # Branches 5.8 and newer should be tested to confirm no regressions are introduced.
           - branch: '5.9'
+            workflow: 'end-to-end-tests.yml'
+          - branch: '5.8'
             workflow: 'end-to-end-tests.yml'
         exclude: