Context Navigation

← Previous Change
Next Change →

update-core.php

Timestamp:

01/17/2022 11:39:35 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Check if the disk_free_space() function exists before calling it.

In PHP 8+, @ no longer suppresses fatal errors:

The @ operator will no longer silence fatal errors (E_ERROR, E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR, E_PARSE).

Reference: PHP 8: Backward Incompatible Changes.

disk_free_space() may be disabled by hosts, which will throw a fatal error on a call to undefined function.

This change prevents the fatal error, and falls back to false when disk_free_space() is unavailable.

Follow-up to [25540], [25774], [25776], [25831], [25869].

Props costdev, jrf, swb1192, SergeyBiryukov.
Fixes #54826. See #54730.

File:

: 1 edited

trunk/src/wp-admin/includes/update-core.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-admin/includes/update-core.php

r52199	r52585
1243	1243	// If we don't have enough free space, it isn't worth trying again.
1244	1244	// Unlikely to be hit due to the check in unzip_file().
1245		$available_space = ~~@disk_free_space( ABSPATH )~~;
	1245	$available_space = function_exists( 'disk_free_space' ) ? @disk_free_space( ABSPATH ) : false;
1246	1246
1247	1247	if ( $available_space && $total_size >= $available_space ) {

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 52585 for trunk/src/wp-admin/includes/update-core.php

Legend:

trunk/src/wp-admin/includes/update-core.php

Download in other formats: