Changeset 52621

Timestamp:

01/24/2022 05:32:28 AM (3 years ago)

Author:

noisysocks

Message:

Customizer: Remove Menus panel when a theme does not support menus

By overriding check_capabilities(), we can ensure that the Menus panel
is removed if a theme does not have support for 'menus' nor 'widgets'.

This ensures that the Menus panel does not appear when using a block
theme, which is confusing to users.

See #54888.
Props hellofromTonya, costdev, peterwilsoncc.

Location:

trunk/src/wp-includes

Files:

• class-wp-customize-panel.php (modified) (1 diff)
• customize/class-wp-customize-nav-menus-panel.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-panel.php

@@ -233 +233 @@
      *
      * @since 4.0.0
+     * @since 5.9.0 Method was marked non-final.
      *
      * @return bool False if theme doesn't support the panel or the user doesn't have the capability.
      */
-    final public function check_capabilities() {
+    public function check_capabilities() {
         if ( $this->capability && ! current_user_can( $this->capability ) ) {
             return false;

trunk/src/wp-includes/customize/class-wp-customize-nav-menus-panel.php

@@ -99 +99 @@
         <?php
     }
+
+    /**
+     * Checks required user capabilities and whether the theme has the
+     * feature support required by the panel.
+     *
+     * @since 5.9.0
+     *
+     * @return bool False if theme doesn't support the panel or the user doesn't have the capability.
+     */
+    public function check_capabilities() {
+        /*
+         * WP_Customize_Panel::$theme_supports only supports checking one
+         * theme_supports, so instead we override check_capabilities().
+         */
+        if (
+            ! current_theme_supports( 'menus' ) &&
+            ! current_theme_supports( 'widgets' )
+        ) {
+            return false;
+        }
+
+        return parent::check_capabilities();
+    }
 }