Changeset 52654

Timestamp:

01/30/2022 07:40:57 PM (5 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Switch to some more appropriate assertions.

See #54725

Location:

trunk/tests/phpunit/tests

Files:

• includes/factory.php (modified) (1 diff)
• term.php (modified) (1 diff)

trunk/tests/phpunit/tests/includes/factory.php

@@ -9 +9 @@
         public function test_create_creates_a_category() {
                 $id = $this->category_factory->create();
-                $this->assertTrue( (bool) get_term_by( 'id', $id, 'category' ) );
+                $this->assertInstanceOf( 'WP_Term', get_term_by( 'id', $id, 'category' ) );
         }
 
         public function test_get_object_by_id_gets_an_object() {
                 $id = $this->category_factory->create();
-                $this->assertTrue( (bool) $this->category_factory->get_object_by_id( $id ) );
+                $this->assertInstanceOf( 'WP_Term', $this->category_factory->get_object_by_id( $id ) );
         }
 

trunk/tests/phpunit/tests/term.php

@@ -124 +124 @@
 
                 foreach ( $posts as $post_id ) {
-                        $this->assertTrue( (bool) wp_delete_post( $post_id ) );
+                        $this->assertInstanceOf( 'WP_Post', wp_delete_post( $post_id ) );
                 }
         }