Changeset 52656 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

02/01/2022 12:12:33 AM (3 years ago)

Author:

peterwilsoncc

Message:

Upgrade: Prevent warnings upgrading cron array.

An unvisited site may have an undefined cron array, resulting in _get_cron_array() returning the value false. Previously this would trigger warning in upgrade_590() as the function assumed _get_cron_array() would alway return an array.

No database version change is required as the upgrade routine was successful on sites with a cron array during 5.9.0. On sites without a cron array, the error has already been thrown if they are running db version 51917. This fix is only required for new sites or those upgrading that have skipped 5.9.0.

Follow up to [51917].

Props chrisvanpatten, kapilpaul, SergeyBiryukov.
Fixes #54906.
See #53940.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (1 diff)

trunk/src/wp-admin/includes/upgrade.php

@@ -2274 +2274 @@
     if ( $wp_current_db_version < 51917 ) {
         $crons = _get_cron_array();
-        // Remove errant `false` values, see #53950.
-        $crons = array_filter( $crons );
-        _set_cron_array( $crons );
+
+        if ( $crons && is_array( $crons ) ) {
+            // Remove errant `false` values, see #53950.
+            $crons = array_filter( $crons );
+            _set_cron_array( $crons );
+        }
     }
 }