Changeset 52669

Timestamp:

02/03/2022 05:41:46 PM (3 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Remove cache expiry limitation in WP_Term_Query.

Remove the one day expiry limitation from query caches found in the WP_Term_Qurery class. Removing this limitation means that the caches will remain in object caching, as long as possible. Ensure that all term / taxonomy cache clear functions invalidate query caches, by deleting the last_changed value in the terms cache group.

Props spacedmonkey, adamsilverstein, boonebgorges, tillkruess, dlh, flixos90.
Fixes #54511.

Location:

trunk/src/wp-includes

Files:

• class-wp-term-query.php (modified) (2 diffs)
• taxonomy.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-term-query.php

@@ -776 +776 @@
 
         if ( empty( $terms ) ) {
-            wp_cache_add( $cache_key, array(), 'terms', DAY_IN_SECONDS );
+            wp_cache_add( $cache_key, array(), 'terms' );
             return array();
         }
@@ -881 +881 @@
         }
 
-        wp_cache_add( $cache_key, $terms, 'terms', DAY_IN_SECONDS );
+        wp_cache_add( $cache_key, $terms, 'terms' );
 
         if ( 'all' === $_fields || 'all_with_object_id' === $_fields ) {

trunk/src/wp-includes/taxonomy.php

@@ -3519 +3519 @@
     }
 
+    wp_cache_delete( 'last_changed', 'terms' );
+
     /**
      * Fires after the object term cache has been cleaned.
@@ -3611 +3613 @@
     wp_cache_delete( 'all_ids', $taxonomy );
     wp_cache_delete( 'get', $taxonomy );
+    wp_cache_delete( 'last_changed', 'terms' );
 
     // Regenerate cached hierarchy.