Changeset 52672 for trunk

Timestamp:

02/04/2022 01:20:30 AM (3 years ago)

Author:

joedolson

Message:

Comments: Only render term update notices on term screens.

Prevent blank notices from appearing when adding custom fields or terms in the post editor.

Props gadhiyaravi, Boniu91, ravipatel, sabernhardt.
Fixes #54955. See #42937.

File:

• trunk/src/js/_enqueues/lib/ajax-response.js (modified) (2 diffs)

trunk/src/js/_enqueues/lib/ajax-response.js

@@ -28 +28 @@
                 response = { action: th.attr('action'), what: child.get(0).nodeName, id: child.attr('id'), oldId: child.attr('old_id'), position: child.attr('position') };
                 response.data = jQuery( 'response_data', child ).text();
-                successmsg += response.data;
+                if ( jQuery( 'body' ).hasClass( 'edit-tags-php' ) ) {
+                    successmsg += response.data;
+                }
                 response.supplemental = {};
                 if ( !jQuery( 'supplemental', child ).children().each( function() {
@@ -51 +53 @@
                 re.html( '<div class="error">' + err + '</div>' );
                 wp.a11y.speak( err );
-            } else {
+            } else if ( successmsg.length ) {
                 re.html( '<div class="updated notice is-dismissible"><p>' + successmsg + '</p></div>');
                 jQuery(document).trigger( 'wp-updates-notice-added' );