Make WordPress Core

Changeset 52695


Ignore:
Timestamp:
02/08/2022 11:39:32 PM (2 years ago)
Author:
audrasjb
Message:

Script Loader: Prevent normalizing HTML IDs in _wp_normalize_relative_css_links().

This change fixes an issue where _wp_normalize_relative_css_links() was not only matching urls, but also HTML IDs.

Follow-up to [52036].

Props mahype, costdev, audrasjb, SergeyBiryukov.
Fixes #54922.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/script-loader.php

    r52673 r52695  
    27712771            }
    27722772
     2773            // Skip if the URL is an HTML ID.
     2774            if ( str_starts_with( $src_result, '#' ) ) {
     2775                continue;
     2776            }
     2777
    27732778            // Build the absolute URL.
    27742779            $absolute_url = dirname( $stylesheet_url ) . '/' . $src_result;
  • trunk/tests/phpunit/tests/dependencies/styles.php

    r52036 r52695  
    196196     *
    197197     * @ticket 54243
     198     * @ticket 54922
    198199     *
    199200     * @covers ::_wp_normalize_relative_css_links
     
    231232                'css'      => 'p {background-image: url(\'http://foo.com/image2.png\');}',
    232233                'expected' => 'p {background-image: url(\'http://foo.com/image2.png\');}',
     234            ),
     235            'An HTML ID'                                   => array(
     236                'css'      => 'clip-path: url(#image1);',
     237                'expected' => 'clip-path: url(#image1);',
    233238            ),
    234239        );
Note: See TracChangeset for help on using the changeset viewer.