Changeset 52695 for trunk

Timestamp:

02/08/2022 11:39:32 PM (5 years ago)

Author:

audrasjb

Message:

Script Loader: Prevent normalizing HTML IDs in _wp_normalize_relative_css_links().

This change fixes an issue where _wp_normalize_relative_css_links() was not only matching urls, but also HTML IDs.

Follow-up to [52036].

Props mahype, costdev, audrasjb, SergeyBiryukov.
Fixes #54922.

Location:

trunk

Files:

• src/wp-includes/script-loader.php (modified) (1 diff)
• tests/phpunit/tests/dependencies/styles.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -2771 +2771 @@
                         }
 
+                        // Skip if the URL is an HTML ID.
+                        if ( str_starts_with( $src_result, '#' ) ) {
+                                continue;
+                        }
+
                         // Build the absolute URL.
                         $absolute_url = dirname( $stylesheet_url ) . '/' . $src_result;

trunk/tests/phpunit/tests/dependencies/styles.php

@@ -196 +196 @@
          *
          * @ticket 54243
+         * @ticket 54922
          *
          * @covers ::_wp_normalize_relative_css_links
@@ -231 +232 @@
                                 'css'      => 'p {background-image: url(\'http://foo.com/image2.png\');}',
                                 'expected' => 'p {background-image: url(\'http://foo.com/image2.png\');}',
+                        ),
+                        'An HTML ID'                                   => array(
+                                'css'      => 'clip-path: url(#image1);',
+                                'expected' => 'clip-path: url(#image1);',
                         ),
                 );