Changeset 52696

Timestamp:

02/09/2022 12:31:27 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use stream_get_contents() in POMO_FileReader::read_all().

stream_get_contents() is faster than fread(), because the PHP core can decide how to best read the remaining file; it could decide to issue just one read() call or mmap() the file first.

Per the PHP manual, file_get_contents() or stream_get_contents() is the preferred way to read the contents of a file into a string. It will use memory mapping techniques if supported by the OS to enhance performance.

Reference: ​PHP Manual: file_get_contents().

Follow-up to [12174].

Props maxkellermann.
See #55069.

File:

• trunk/src/wp-includes/pomo/streams.php (modified) (1 diff)

trunk/src/wp-includes/pomo/streams.php

@@ -218 +218 @@
                  */
                 public function read_all() {
-                        $all = '';
-                        while ( ! $this->feof() ) {
-                                $all .= $this->read( 4096 );
-                        }
-                        return $all;
+                        return stream_get_contents( $this->_f );
                 }
         }