Changeset 52698 for trunk/src/wp-includes/functions.php

Timestamp:

02/10/2022 03:01:06 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use file_get_contents() in get_file_data().

file_get_contents() is faster than fread(), because the PHP core can decide how to best read the remaining file; it could decide to issue just one read() call or mmap() the file first.

Per the PHP manual, file_get_contents() or stream_get_contents() is the preferred way to read the contents of a file into a string. It will use memory mapping techniques if supported by the OS to enhance performance.

Reference: ​PHP Manual: file_get_contents().

Follow-up to [12044], [49073], [52696].

Props maxkellermann.
See #55069.

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -6567 +6567 @@
  */
 function get_file_data( $file, $default_headers, $context = '' ) {
-    // We don't need to write to the file, so just open for reading.
-    $fp = fopen( $file, 'r' );
-
-    if ( $fp ) {
-        // Pull only the first 8 KB of the file in.
-        $file_data = fread( $fp, 8 * KB_IN_BYTES );
-
-        // PHP will close file handle, but we are good citizens.
-        fclose( $fp );
-    } else {
+    // Pull only the first 8 KB of the file in.
+    $file_data = file_get_contents( $file, false, null, 0, 8 * KB_IN_BYTES );
+
+    if ( false === $file_data ) {
         $file_data = '';
     }