Changeset 52701

Timestamp:

02/11/2022 03:48:44 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use file_get_contents() in wp_get_image_mime().

file_get_contents() is faster than fread(), because the PHP core can decide how to best read the remaining file; it could decide to issue just one read() call or mmap() the file first.

Per the PHP manual, file_get_contents() or stream_get_contents() is the preferred way to read the contents of a file into a string. It will use memory mapping techniques if supported by the OS to enhance performance.

Reference: ​PHP Manual: file_get_contents().

Follow-up to [50810], [52696], [52698].

Props maxkellermann.
See #55069.

File:

• trunk/src/wp-includes/functions.php (modified) (2 diffs)

trunk/src/wp-includes/functions.php

@@ -3266 +3266 @@
         }
 
-        $handle = fopen( $file, 'rb' );
-        if ( false === $handle ) {
-            return false;
-        }
-
-        $magic = fread( $handle, 12 );
+        $magic = file_get_contents( $file, false, null, 0, 12 );
+
         if ( false === $magic ) {
             return false;
@@ -3290 +3286 @@
             $mime = 'image/webp';
         }
-
-        fclose( $handle );
     } catch ( Exception $e ) {
         $mime = false;