Changeset 52707 for trunk/src/wp-includes/comment.php

Timestamp:

02/11/2022 06:50:08 PM (3 years ago)

Author:

spacedmonkey

Message:

Cache: Use wp_cache_*_multiple() in core functions.

Implement the wp_cache_add_multiple, wp_cache_set_multiple and wp_cache_delete_multiple in a number of core functions after they were introduced in [52700]

Props: spacedmonkey, adamsilverstein, flixos90, mitogh.
Fixes: #55029.

File:

• trunk/src/wp-includes/comment.php (modified) (4 diffs)

trunk/src/wp-includes/comment.php

@@ -1884 +1884 @@
 function _clear_modified_cache_on_transition_comment_status( $new_status, $old_status ) {
     if ( 'approved' === $new_status || 'approved' === $old_status ) {
+        $data = array();
         foreach ( array( 'server', 'gmt', 'blog' ) as $timezone ) {
-            wp_cache_delete( "lastcommentmodified:$timezone", 'timeinfo' );
-        }
+            $data[] = "lastcommentmodified:$timezone";
+        }
+        wp_cache_delete_multiple( $data, 'timeinfo' );
     }
 }
@@ -2046 +2048 @@
         wp_update_comment_count( $comment_post_ID );
 
+        $data = array();
         foreach ( array( 'server', 'gmt', 'blog' ) as $timezone ) {
-            wp_cache_delete( "lastcommentmodified:$timezone", 'timeinfo' );
-        }
+            $data[] = "lastcommentmodified:$timezone";
+        }
+        wp_cache_delete_multiple( $data, 'timeinfo' );
     }
 
@@ -3221 +3225 @@
  */
 function clean_comment_cache( $ids ) {
-    foreach ( (array) $ids as $id ) {
-        wp_cache_delete( $id, 'comment' );
-
+    $comment_ids = (array) $ids;
+    wp_cache_delete_multiple( $comment_ids, 'comment' );
+    foreach ( $comment_ids as $id ) {
         /**
          * Fires immediately after a comment has been removed from the object cache.
@@ -3251 +3255 @@
  */
 function update_comment_cache( $comments, $update_meta_cache = true ) {
+    $data = array();
     foreach ( (array) $comments as $comment ) {
-        wp_cache_add( $comment->comment_ID, $comment, 'comment' );
-    }
+        $data[ $comment->comment_ID ] = $comment;
+    }
+    wp_cache_add_multiple( $data, 'comment' );
 
     if ( $update_meta_cache ) {